Remove hacks fixed by vexflow 5.0.0-beta.1#275

Merged

jaredjj3 merged 2 commits intomasterfrom

Feb 26, 2025

Collaborator

jaredjj3 commented Feb 26, 2025 •

edited

Loading

✅ Removed hack: update to vexflow beta #233 (comment)
❌ Could not remove hack: Articulation draw is not idempotent vexflow/vexflow#254 (comment)
❌ Could not remove hack: GraceTabNote font size vexflow/vexflow#255 (comment)


          remove vexflow.KeySignature stave hack

fdbd474

jaredjj3 self-assigned this

This was referenced Feb 26, 2025

update to vexflow beta #233

Closed

Articulation draw is not idempotent vexflow/vexflow#254

Open


          delete legacy snapshots

89c7851

Collaborator Author

jaredjj3 commented Feb 26, 2025 •

edited

Loading

✅ Removed hack: update to vexflow beta #233 (comment)
❌ Could not remove hack (fixing this would improve rendering speed up to 30%): Articulation draw is not idempotent vexflow/vexflow#254 (comment)
❌ Could not remove hack: GraceTabNote font size vexflow/vexflow#255 (comment)

jaredjj3 marked this pull request as ready for review

February 26, 2025 01:14

jaredjj3 merged commit fd2e539 into master

1 check passed

jaredjj3 deleted the cleanup branch

February 26, 2025 01:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet